Skip to content

fix(webpack-plugin): forward headers option to sentry-cli #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

fix(webpack-plugin): forward headers option to sentry-cli #797

merged 1 commit into from
Aug 28, 2025
+1 −0

Conversation

liAmirali
Copy link
Contributor

Closes #796

  • Problem: The headers option is ignored in the sentryWebpackPlugin.
  • Solution: Pass options.headers to SentryCli in createCliInstance method.
  • Impact: Enables use of custom custom headers

andreiborza
andreiborza approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for fixing this. We recently removed this and caused a regression 😅 .

@andreiborza andreiborza requested a review from chargome August 28, 2025 12:55
chargome
chargome approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chargome chargome merged commit 00ae21f into getsentry:main Aug 28, 2025
22 of 23 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 1, 2025
@renovate
Update dependency @sentry/vite-plugin to v4.2.0
380ed0e 
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | @sentry/vite-plugin | 4.1.1 | 4.2.0 |


## [v4.2.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#420)

- feat(core): Add `prepareArtifacts` option for uploading sourcemaps ([#794](getsentry/sentry-javascript-bundler-plugins#794))
- perf: use premove for build clean ([#792](getsentry/sentry-javascript-bundler-plugins#792))
- fix(core): Forward headers option to sentry-cli ([#797](getsentry/sentry-javascript-bundler-plugins#797))

Work in this release contributed by [@liAmirali](https://github.com/liAmirali). Thank you for your contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

@andreiborza andreiborza andreiborza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Bug: headers option does not set custom HTTP headers
3 participants
@liAmirali @chargome @andreiborza